Strawly-Music/desktop
Strawly-Music/desktop
Watch
1
0
Fork
You've already forked desktop
 0
Code Issues Pull requests Releases 8 Activity Actions

Check pull requests for warnings, build the Flatpak after merging, and publish release checksums #14

Merged
GrumpyStraw merged 3 commits from release-checksums into main 2026-10-11 21:55:05 +02:00
Conversation 0 Commits 3 Files changed 6 +78 -36
GrumpyStraw commented 2026-10-11 21:43:17 +02:00
Owner

Pull request checks

A new workflow, Pull request checks, runs .forgejo/check.sh in the KDE SDK on every pull request: rustfmt, clippy with -D warnings, the build with C++ warnings as errors, qmllint and the tests. Any warning fails it. Before this, CI built and tested the code but checked no warnings.

The README's test command runs the same script, so a local check and the CI's are the same.

Build and release

The old workflow is now Build and release. It builds the Flatpak after each merge to main, as a test bundle, and for a v* tag also publishes the release. It no longer runs on pull requests, which saves about 9 minutes per pull request, and it does not run the tests again.

Each bundle now comes with a SHA256SUMS file, and the README's install steps check the download against it.

Names

File Workflow Jobs
pull-request-checks.yml Pull request checks Lint and test
build-and-release.yml Build and release Build the Flatpak, Publish the release
ci-image-updates.yml CI image updates Compare with Flathub

Branch protection on main needs the new required check, Pull request checks / Lint and test (pull_request), once this pull request has run it.

Checked

check.sh passes on this branch in the KDE SDK. With an unknown QML property it fails at qmllint, and with an unused Rust variable it fails at clippy.

## Pull request checks A new workflow, **Pull request checks**, runs `.forgejo/check.sh` in the KDE SDK on every pull request: rustfmt, clippy with `-D warnings`, the build with C++ warnings as errors, qmllint and the tests. Any warning fails it. Before this, CI built and tested the code but checked no warnings. The README's test command runs the same script, so a local check and the CI's are the same. ## Build and release The old workflow is now **Build and release**. It builds the Flatpak after each merge to `main`, as a test bundle, and for a `v*` tag also publishes the release. It no longer runs on pull requests, which saves about 9 minutes per pull request, and it does not run the tests again. Each bundle now comes with a `SHA256SUMS` file, and the README's install steps check the download against it. ## Names | File | Workflow | Jobs | | --- | --- | --- | | `pull-request-checks.yml` | Pull request checks | Lint and test | | `build-and-release.yml` | Build and release | Build the Flatpak, Publish the release | | `ci-image-updates.yml` | CI image updates | Compare with Flathub | Branch protection on `main` needs the new required check, `Pull request checks / Lint and test (pull_request)`, once this pull request has run it. ## Checked `check.sh` passes on this branch in the KDE SDK. With an unknown QML property it fails at qmllint, and with an unused Rust variable it fails at clippy. 
The README's install steps check the download against it.
Pull requests run .forgejo/check.sh in the KDE SDK: rustfmt, clippy,
the build with C++ warnings as errors, qmllint and the tests. Any
warning fails the check, which nothing in CI checked before. The
Flatpak build moves to the Package workflow, which runs after each
merge to main and for v* tags, so a pull request no longer builds the
bundle. The README's test command runs the same script.
Name the workflows after what they do
All checks were successful
Pull request checks / Lint and test (pull_request) Successful in 6m6s
Details
04923b51ca 
Pull request checks (Lint and test), Build and release (Build the
Flatpak, Publish the release) and CI image updates (Compare with
Flathub).
GrumpyStraw deleted branch release-checksums 2026-10-11 21:55:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Kind/Bug
Something isn't working

  
Kind/Chore
Maintenance, refactor, tooling, or dependency work

  
Kind/Docs
Documentation only, no code change

  
Kind/Feature
New capability or module

  
Kind/Security
Vulnerability, hardening, or compliance-related

  
Priority
High
 Ahead of everything else in the backlog

  
Priority
Low
 Someday, not blocking anything

  
Reviewed
Duplicate
 Already tracked elsewhere

  
Reviewed
Invalid
 Not a real issue

  
Status
Blocked
 Waiting on something external before work can continue

  
Status
Needs-Decision
 Needs a product decision before it's ready to build

  
Status
Wontfix
 Deliberately not doing this

No labels
Kind/Bug
Kind/Chore
Kind/Docs
Kind/Feature
Kind/Security
Priority
High
Priority
Low
Reviewed
Duplicate
Reviewed
Invalid
Status
Blocked
Status
Needs-Decision
Status
Wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
GrumpyStraw
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
Strawly-Music/desktop!14
No description provided.